[Polysemy] Introduce an Effect for Password Resetting #2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdimjasevic
force-pushed
the
polysemy-brig/code-store-effect
branch
from
b6fdfb4 to
bd0552f
Compare
mdimjasevic
force-pushed
the
polysemy-brig/code-store-effect
branch
from
bd0552f to
2fdad3d
Compare
isovector
reviewed
Apr 14, 2022
isovector
reviewed
Apr 14, 2022
isovector
reviewed
Apr 14, 2022
mdimjasevic
changed the title
- This allows for using the Now effect with other time types than 'SAML2.WebSSO.Types.Time'.
- This effect is generally useful and it will be used in services other than Spar
mdimjasevic
force-pushed
the
polysemy-brig/code-store-effect
branch
from
7216817 to
f5e9174
Compare
mdimjasevic
changed the base branch from
develop
to
mdimjasevic/now-effect-into-lib
mdimjasevic
force-pushed
the
polysemy-brig/code-store-effect
branch
from
f5e9174 to
61cf690
Compare
mdimjasevic
force-pushed
the
polysemy-brig/code-store-effect
branch
from
61cf690 to
8915e90
Compare
5 tasks
- This is essentially the same function, but it's been reloacted to a library as it is not specific to Brig
- an Embed Cas.Client effect will always be needed as some effects like CodeStore are interpreted to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces the first Polysemy-based effects to Brig. One effect is for a code store. Combined with
Now(PR #2292), it is combined into a higher-level effect for password resetting.In some places an effect is immediately interpreted at the use site; this is to avoid introducing embeddings of various constrained monads. As more effects will be introduced in subsequent PRs, it will be possible to bubble up these interpretations and eventually have them only at the very top level when running the application.
Checklist
changelog.d.