Skip to content

Servantify Galley Teams [1/3] #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 6, 2022

Conversation

stephen-smith
Copy link
Contributor

@stephen-smith stephen-smith commented Apr 5, 2022

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.

JIRA: https://wearezeta.atlassian.net/browse/SQSERVICES-1080

  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.

No endpoints were supposed to be added or renamed, but they are now specified in servant type instead of wai-routes paths, so this should be a point of review.

  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need an upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@stephen-smith stephen-smith requested review from smatting and fisx April 5, 2022 18:51
@stephen-smith stephen-smith self-assigned this Apr 5, 2022
@stephen-smith stephen-smith temporarily deployed to cachix April 5, 2022 18:52 Inactive
@stephen-smith stephen-smith temporarily deployed to cachix April 5, 2022 18:56 Inactive
@stephen-smith stephen-smith merged commit ea7cfab into develop Apr 6, 2022
@stephen-smith stephen-smith deleted the boyd.smith/servantify-galley-teams branch April 6, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants