Skip to content

Spar debugging #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 17, 2022
Merged

Spar debugging #2214

merged 9 commits into from
Mar 17, 2022

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Mar 16, 2022 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQSERVICES-1376

  • clarify semantics of internal functions
  • crank up logging of SCIM CRUD API
  • remove redundant log entries
  • improve test coverage

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

battermann and others added 8 commits March 15, 2022 13:43
@battermann
find user by email + refactoring
5415e05
@fisx
Cleanup.
8ecaf89
@fisx
[Experiment] try post.
1d0f0fb 
This emulates scim peer behavior that makes no sense.  I was trying to
reproduce an exceedingly evasive production issue, but instead of
successfully (and erroneously) creating a broken duplicate user, this
test fails as desired with "externalId is already taken".
@fisx
Revert "[Experiment] try post."
781ba9a 
This reverts commit 1d0f0fb.
@fisx
Log more UserId in scim end-points (level info).
511d108
@fisx
Remove redundant log entries.
ae20719 
(This is already logged inside `deleteScimUser`.)
@fisx
Update user index tables in spar more exhaustively.
7ad416d 
Do this by specializing runExternalId combinator (it was a bit vague
before).  This also has the effect of making the semantics in a few
places clearer (and more correct?).
@fisx
changelog
c234a41
@fisx fisx force-pushed the SQSERVICES-1376-spar-debugging branch from 5f4123c to c234a41 Compare March 16, 2022 22:03
@fisx fisx requested a review from battermann March 16, 2022 22:03
battermann
battermann approved these changes Mar 17, 2022
View reviewed changes
@fisx fisx merged commit b729152 into develop Mar 17, 2022
@fisx fisx deleted the SQSERVICES-1376-spar-debugging branch March 17, 2022 11:47
@zebot zebot mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisx @battermann