Skip to content

Add ToSchema instances for QueuedNotification and QueuedNotificationList #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Feb 25, 2022

Motivation: Unit tests for roundtrip tests are slow

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti force-pushed the remove-queued-notification-roundtrip branch from 6535bc1 to 0a8d273 Compare February 28, 2022 08:02
Also remove roundtrip tests
@pcapriotti pcapriotti force-pushed the remove-queued-notification-roundtrip branch from 0a8d273 to d3f7cb8 Compare February 28, 2022 08:14
@pcapriotti pcapriotti marked this pull request as ready for review February 28, 2022 09:04
@smatting
Copy link
Contributor Author

Thanks @pcapriotti

@smatting smatting merged commit cf6cf7b into develop Feb 28, 2022
@smatting smatting deleted the remove-queued-notification-roundtrip branch February 28, 2022 09:30
@zebot zebot mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants