Skip to content

Fix version bounds. #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Fix version bounds. #2157

merged 2 commits into from
Feb 25, 2022

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Feb 24, 2022

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why putting an upper bound on aeson?

@fisx
Copy link
Contributor Author

fisx commented Feb 24, 2022

Why putting an upper bound on aeson?

same reason we always put upper version bounds. semantic versioning rules about legal breaking changes.

@pcapriotti
Copy link
Contributor

Probably a stupid question, but couldn't we just get rid of all the version bounds and simply rely on cabal.freeze?

@mdimjasevic
Copy link
Contributor

Probably a stupid question, but couldn't we just get rid of all the version bounds and simply rely on cabal.freeze?

@fisx , I'm curious about the same: can't we address the concern via the freeze file?

@fisx
Copy link
Contributor Author

fisx commented Feb 24, 2022

not a stupid question, this just goes against the idea of how packages work as self-contained entities, especially library packages. one could argue that we don't make those, and they are not self-contained for many other reasons besides the inconsistently applied version bounds in the cabal files. i just had the urge to clean up a little bit.

i think this discussion is becoming much bigger than this PR, though. :)

@fisx fisx merged commit 4ab3959 into develop Feb 25, 2022
@fisx fisx deleted the fix-version-bounds branch February 25, 2022 08:21
@zebot zebot mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants