Skip to content

Sqservices 1157 backend 2nd auth factor for create authentication token for SCIM service impl #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Feb 22, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-1157

Todo

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@battermann battermann force-pushed the SQSERVICES-1157-backend-2nd-auth-factor-for-create-authentication-token-for-scim-service-impl branch 3 times, most recently from c3e8d4e to 9e0f1c8 Compare February 25, 2022 13:07
@battermann battermann force-pushed the SQSERVICES-1157-backend-2nd-auth-factor-for-create-authentication-token-for-scim-service-impl branch from 94e5f23 to aee5487 Compare March 2, 2022 16:48
@battermann battermann force-pushed the SQSERVICES-1162-backend-2nd-auth-factor-for-login branch from b4f2915 to 562fb72 Compare March 2, 2022 16:52
@battermann battermann force-pushed the SQSERVICES-1157-backend-2nd-auth-factor-for-create-authentication-token-for-scim-service-impl branch from aee5487 to 81dc5ae Compare March 3, 2022 09:00
@battermann battermann marked this pull request as ready for review March 3, 2022 09:00
@battermann battermann requested a review from fisx March 3, 2022 09:00
@battermann battermann force-pushed the SQSERVICES-1157-backend-2nd-auth-factor-for-create-authentication-token-for-scim-service-impl branch 5 times, most recently from 6d88b82 to fa5036f Compare March 10, 2022 11:58
Base automatically changed from SQSERVICES-1162-backend-2nd-auth-factor-for-login to develop March 10, 2022 12:58
@battermann battermann force-pushed the SQSERVICES-1157-backend-2nd-auth-factor-for-create-authentication-token-for-scim-service-impl branch from 53cc19e to cc814ac Compare March 10, 2022 13:30
@fisx
Copy link
Contributor

fisx commented Mar 10, 2022

  test-integration/Test/Spar/Scim/AuthSpec.hs:149:7:
  1) WireIdPAPIV1.Spar.Scim.Auth, POST /auth-tokens, works with verification code
       uncaught exception: ErrorCall
       Assertions failed:
        1: 200 =/= 404

       Response was:

       Response {responseStatus = Status {statusCode = 404, statusMessage = "Not Found"}, responseVersion = HTTP/1.1, responseHeaders = [("Transfer-Encoding","chunked"),("Date","Thu, 10 Mar 2022 20:33:43 GMT"),("Server","Warp/3.3.17"),("Vary","Accept-Encoding"),("Content-Encoding","gzip"),("Content-Type","application/json")], responseBody = Just "{\"code\":404,\"label\":\"no-endpoint\",\"message\":\"The requested endpoint does not exist\"}", responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}
       CallStack (from HasCallStack):
         error, called at src/Bilge/Assert.hs:89:5 in bilge-0.22.0-inplace:Bilge.Assert
         <!!, called at test-integration/Test/Spar/Scim/AuthSpec.hs:149:7 in main:Test.Spar.Scim.AuthSpec

  To rerun use: --match "/WireIdPAPIV1/Spar.Scim.Auth/POST /auth-tokens/works with verification code/"

  test-integration/Test/Spar/Scim/AuthSpec.hs:149:7:
  2) WireIdPAPIV2.Spar.Scim.Auth, POST /auth-tokens, works with verification code
       uncaught exception: ErrorCall
       Assertions failed:
        1: 200 =/= 404

       Response was:

       Response {responseStatus = Status {statusCode = 404, statusMessage = "Not Found"}, responseVersion = HTTP/1.1, responseHeaders = [("Transfer-Encoding","chunked"),("Date","Thu, 10 Mar 2022 20:35:53 GMT"),("Server","Warp/3.3.17"),("Vary","Accept-Encoding"),("Content-Encoding","gzip"),("Content-Type","application/json")], responseBody = Just "{\"code\":404,\"label\":\"no-endpoint\",\"message\":\"The requested endpoint does not exist\"}", responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}
       CallStack (from HasCallStack):
         error, called at src/Bilge/Assert.hs:89:5 in bilge-0.22.0-inplace:Bilge.Assert
         <!!, called at test-integration/Test/Spar/Scim/AuthSpec.hs:149:7 in main:Test.Spar.Scim.AuthSpec

  To rerun use: --match "/WireIdPAPIV2/Spar.Scim.Auth/POST /auth-tokens/works with verification code/"

seems related. i'll check if these pass locally on my machine. if so: maybe a timing issue that only materializes on a k8s cluster, but not on localhost?

@fisx
Copy link
Contributor

fisx commented Mar 10, 2022

i'll check if these pass locally on my machine.

nope, fails for me on my laptop as well.

@fisx
Copy link
Contributor

fisx commented Mar 12, 2022

integration tests passed locally.

@fisx fisx merged commit 9a6ac54 into develop Mar 13, 2022
@fisx fisx deleted the SQSERVICES-1157-backend-2nd-auth-factor-for-create-authentication-token-for-scim-service-impl branch March 13, 2022 09:08
@zebot zebot mentioned this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants