-
Notifications
You must be signed in to change notification settings - Fork 332
MLS Message types #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLS Message types #2145
Conversation
6ae2d14
to
631e529
Compare
9e4c77d
to
3e46af1
Compare
8d240f8
to
39c8741
Compare
b3fbf66
to
cebb3a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Many of the data types you introduce in this PR have fields of Word* types. Would it make sense to wrap them with newtype
s? If so, I would find such an alternative easier to read: once parsed, I don't care how many bytes something was in its serialised form, and on the other hand a solid type name might suggest what it is for, and it makes it harder to confuse values of the same Word* type.
I think it would just add a lot of noise with not that many benefits, in this case. |
* MLS message deserialisation * Add simple message unit test * Add application message unit test * Implement welcome message deserialisation
* MLS message deserialisation * Add simple message unit test * Add application message unit test * Implement welcome message deserialisation
This PR implements deserialisation for MLS message types
Checklist
changelog.d
.