Skip to content

Implement remote admin action: Update receipt mode #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Feb 17, 2022

This PR is the first in a series of PR that add missing implemention of conversation actions when the admin is remote (i.e. the admin is on a backend that doesn't own the conversation).

This PR implements functionality for the receipt mode update in the Client API

PUT /conversations/:domain/:conversation/receipt-mode

when :domain is a domain that is remote to the user calling the endpoint.

This PR also introduces a Federation API RPC update-conversation which is used by a backend to request a conversation update on the backend that owns the conversation. The requested action is any one of the supported conversation actions:

  • ConversationJoin
  • ConversationLeave
  • ConversationRemoveMembers
  • ConversationMemberUpdate
  • ConversationDelete
  • ConversationRename
  • ConversationMessageTimerUpdate
  • ConversationReceiptModeUpdate (gets used by /conversations/:domain/:conversation/receipt-mode)
  • ConversationAccessData

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@smatting smatting changed the title WIP: Impelment remote admin actions WIP: Implement remote admin actions Feb 21, 2022
@smatting smatting force-pushed the FS-216-remote-admins branch 3 times, most recently from 9bd9317 to 9dd8ec7 Compare February 25, 2022 12:29
@smatting smatting force-pushed the FS-216-remote-admins branch from 55b7418 to 3f80a66 Compare March 2, 2022 14:44
@smatting smatting force-pushed the FS-216-remote-admins branch from 3f80a66 to 606e436 Compare April 5, 2022 15:23
@smatting smatting temporarily deployed to cachix April 5, 2022 15:23 Inactive
@smatting smatting temporarily deployed to cachix April 6, 2022 16:19 Inactive
@smatting smatting force-pushed the FS-216-remote-admins branch from 48a6377 to e5adf91 Compare April 20, 2022 16:08
@smatting smatting temporarily deployed to cachix April 20, 2022 16:08 Inactive
@smatting smatting force-pushed the FS-216-remote-admins branch from e5adf91 to 93fc4c3 Compare April 22, 2022 11:36
@smatting smatting force-pushed the FS-216-remote-admins branch from 93fc4c3 to f6af265 Compare April 28, 2022 11:08
@smatting smatting temporarily deployed to cachix April 28, 2022 11:09 Inactive
@smatting smatting force-pushed the FS-216-remote-admins branch from f6af265 to 83f49e9 Compare April 28, 2022 14:26
@smatting smatting temporarily deployed to cachix April 28, 2022 14:26 Inactive
@smatting smatting force-pushed the FS-216-remote-admins branch from 83f49e9 to 0a2c178 Compare April 28, 2022 15:48
@smatting smatting temporarily deployed to cachix April 28, 2022 15:48 Inactive
@smatting smatting changed the title WIP: Implement remote admin actions Implement remote admin action: Update receipt mode Apr 29, 2022
@smatting smatting temporarily deployed to cachix April 29, 2022 15:58 Inactive
@smatting smatting marked this pull request as ready for review April 29, 2022 15:58
@smatting smatting merged commit 853f738 into develop May 2, 2022
@smatting smatting deleted the FS-216-remote-admins branch May 2, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants