Skip to content

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Feb 10, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-1157

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If public end-points have been changed or added: does nginz need un upgrade?

Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far!

@battermann battermann force-pushed the SQSERVICES-1157-2MF-for-generating-SCIM-token branch from c7717be to f7c11de Compare February 11, 2022 10:47
@battermann battermann marked this pull request as ready for review February 14, 2022 13:26
@battermann battermann requested a review from fisx February 14, 2022 13:26
@battermann battermann changed the title 2nd Auth Factor for "Create authentication token for SCIM service" 2nd Auth Factor for "Create authentication token for SCIM service" and "login" API Feb 15, 2022
@battermann battermann requested a review from fisx February 15, 2022 11:53
@fisx fisx merged commit ae447b1 into develop Feb 15, 2022
@fisx fisx deleted the SQSERVICES-1157-2MF-for-generating-SCIM-token branch February 15, 2022 14:28
@fisx fisx mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants