Skip to content

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Feb 9, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-1029

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md

@battermann battermann force-pushed the SQSERVICES-1029-Refine-TeamFeatureValidateSAMLEmails branch from 1b5f772 to 8e77c37 Compare February 9, 2022 12:34
@battermann battermann marked this pull request as ready for review February 9, 2022 12:49
@battermann battermann requested a review from fisx February 9, 2022 12:51
@fisx
Copy link
Contributor

fisx commented Feb 9, 2022

looks related

Failures:

  test-integration/Test/Spar/Scim/UserSpec.hs:1714:37: 
  1) WireIdPAPIV1.Spar.Scim.User, email validation, not enabled in team, does not give user email
       uncaught exception: HUnitFailure
       HUnitFailure (Just (SrcLoc {srcLocPackage = "main", srcLocModule = "Test.Spar.Scim.UserSpec", srcLocFile = "test-integration/Test/Spar/Scim/UserSpec.hs", srcLocStartLine = 1715, srcLocStartCol = 19, srcLocEndLine = 1715, srcLocEndCol = 30})) "there should be no pending activation\nexpected: Just (ActivationKey {fromActivationKey = AsciiText {toText = \"YN-S4zm89HCCu48mq1SIYNDsU5TkvhZusg5ajbVrLRs=\"}},ActivationCode {fromActivationCode = AsciiText {toText = \"606375\"}})\n but got: Nothing"

  To rerun use: --match "/WireIdPAPIV1/Spar.Scim.User/email validation/not enabled in team/does not give user email/"

  test-integration/Test/Spar/Scim/UserSpec.hs:1714:37: 
  2) WireIdPAPIV2.Spar.Scim.User, email validation, not enabled in team, does not give user email
       uncaught exception: HUnitFailure
       HUnitFailure (Just (SrcLoc {srcLocPackage = "main", srcLocModule = "Test.Spar.Scim.UserSpec", srcLocFile = "test-integration/Test/Spar/Scim/UserSpec.hs", srcLocStartLine = 1715, srcLocStartCol = 19, srcLocEndLine = 1715, srcLocEndCol = 30})) "there should be no pending activation\nexpected: Just (ActivationKey {fromActivationKey = AsciiText {toText = \"wvUgXxWAJLnQ2aEeSW2PDvfMw9UGFWJiALGdblJIiOI=\"}},ActivationCode {fromActivationCode = AsciiText {toText = \"285824\"}})\n but got: Nothing"

Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to take a break, I'll finish the review later.

@fisx fisx merged commit f5f9f4b into develop Feb 9, 2022
@fisx fisx deleted the SQSERVICES-1029-Refine-TeamFeatureValidateSAMLEmails branch February 9, 2022 19:44
@fisx fisx mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants