-
Notifications
You must be signed in to change notification settings - Fork 332
MLS key packages #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
MLS key packages #2102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76020d3
to
1d103c4
Compare
60f7f7a
to
f006449
Compare
47af6d5
to
e4e9e91
Compare
2 tasks
d9562cf
to
4ae72e5
Compare
6ae2d14
to
631e529
Compare
mdimjasevic
reviewed
Feb 25, 2022
mdimjasevic
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I have some minor questions; they're inlined.
The current format is `uid:cid@domain`, which agrees with the way identities are serialised in core-crypto.
Co-authored-by: Marko Dimjašević <[email protected]>
8d240f8
to
39c8741
Compare
Co-authored-by: Marko Dimjašević <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of MLS key package API. This PR introduces 3 new endpoints for managing key packages, and corresponding schema changes:
POST /mls/key-packages/self/:client
GET /mls/key-packages/self/:client/count
POST /mls/key-packages/claim/:domain/:user
Key packages are claimed with a locking strategy similar to that for prekeys (in the absence of DynamoDB).
This PR also introduces some basic MLS types and corresponding deserialisation primitives (for its default TLS encoding).
Only local behaviour is implemented in this PR. Federation behaviour, as well as key package mapping (needed in order to be able to resolve key package refs to qualified client IDs), is left for future PRs.
Note: integration tests rely on the
crypto-cli
tool being in the path. The tool can be found here (note that it is a branch).Tracked by https://wearezeta.atlassian.net/browse/FS-431.
TODO
crypto-cli
in the dev environmentcrypto-cli
in CIChecklist
make git-add-cassandra-schema
to update the cassandra schema documentation.changelog.d
.