-
Notifications
You must be signed in to change notification settings - Fork 333
Introduce named routes in brig #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation to the new format looks good. IMHO it's better to read. 👍
Only a few minor questions...
7a4d50c
to
8e6d28c
Compare
Thanks for reviewing. Unfortunately, since the PR contained a merge of #2091 (to avoid having to deal with conflicts later), you have also looked at some changes from the other PR. I have rebased now. Fixed the typo and readded the missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
This PR is the brig counterpart to #2022, i.e. it replaces uses of servant-generic in brig with
Named
routes, and splits the API tree into sections.Checklist
changelog.d
.