Skip to content

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Feb 3, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-1239

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the context for this, but I'm assuming it's just an option that is not used anymore?

@battermann
Copy link
Contributor Author

I don't know the context for this, but I'm assuming it's just an option that is not used anymore?

Kind of, the option has a hard coded default. And since overwriting by helm template is not supported, it can better be removed to avoid confusion.

@battermann battermann merged commit e8595a0 into develop Feb 4, 2022
@battermann battermann deleted the SQSERVICES-1239-remove-unused-locale-setting branch February 4, 2022 08:57
@fisx fisx mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants