SQSERVICES-1232 Prevent CSV Injection #2096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battermann
requested review from
smatting,
akshaymankar,
pcapriotti,
jschaul,
fisx and
mdimjasevic
and removed request for
smatting
battermann
changed the title
battermann
force-pushed
the
SQSERVICES-1232-csv-injection-defense
branch
from
98737ea to
7efa102
Compare
smatting
approved these changes
Feb 7, 2022
fisx
reviewed
Feb 8, 2022
|
|
||
| unquoted :: ByteString -> ByteString | ||
| unquoted bstr = case C.uncons bstr of | ||
| Just ('\'', t) -> t |
There was a problem hiding this comment.
what if there is more than one \' in there?
fisx
reviewed
Feb 8, 2022
| _ -> False | ||
|
|
||
| testQuotedProp :: TestTree | ||
| testQuotedProp = testProperty "quoted" prop |
There was a problem hiding this comment.
"quoted arbitrary", for symmetry.
| tests :: TestTree | ||
| tests = | ||
| testGroup | ||
| "Export" |
There was a problem hiding this comment.
it's really just about quoted, unquoted, so you could be more specific here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1232
Checklist
changelog.d.