Skip to content

[FS-333] Tag Test Cases for M2 #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 19, 2022
Merged

[FS-333] Tag Test Cases for M2 #2045

merged 6 commits into from
Jan 19, 2022

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Jan 14, 2022 •
edited
Loading

This implements https://wearezeta.atlassian.net/browse/FS-333.

Still to do:

  • Tag a test case for getting a conversation

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@mdimjasevic mdimjasevic force-pushed the fs-333/mdimjasevic-doc-test-cases-m2-release branch 2 times, most recently from d48e007 to 0fabf8f Compare January 17, 2022 10:39
@mdimjasevic mdimjasevic marked this pull request as ready for review January 17, 2022 10:40
mythsunwind
mythsunwind suggested changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@mythsunwind mythsunwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One END tag is missing. Otherwise great work nicely documented with your comments!

@mdimjasevic mdimjasevic force-pushed the fs-333/mdimjasevic-doc-test-cases-m2-release branch from 0fabf8f to e5c3b81 Compare January 17, 2022 14:45
pcapriotti
pcapriotti requested changes Jan 18, 2022
View reviewed changes
@mdimjasevic mdimjasevic force-pushed the fs-333/mdimjasevic-doc-test-cases-m2-release branch from 5c5a4d2 to 4e62f0c Compare January 19, 2022 08:54
@mdimjasevic mdimjasevic force-pushed the fs-333/mdimjasevic-doc-test-cases-m2-release branch from 86c5154 to 998cbdf Compare January 19, 2022 09:12
@mdimjasevic
Tag a negative test case for X509v3 Extended Key Usage
1dff2ec 
- The test makes sure that the server certificate has to have an
extension marking its purpose for server authentication
@mdimjasevic
Tag a test for remote user removal when guests disallowed
d32a9a5 
- When the access is updated such that it disallows guests from
accessing, all guests, both local and remote, are kicked out of the
conversation. This just tags such a test case.
@mdimjasevic
Add a changelog
6b52278
@mdimjasevic
Tag a negative test for getting remote conversation details
ee60cf7
@mdimjasevic
Move a comment around a test case to top level
947ec4f
@mdimjasevic
Fix the wording of a test case description
3ff5eaf 
- This comes from Paolo Capriotti's feedback
@mdimjasevic mdimjasevic force-pushed the fs-333/mdimjasevic-doc-test-cases-m2-release branch from 998cbdf to 3ff5eaf Compare January 19, 2022 12:21
@mdimjasevic mdimjasevic merged commit c8f50d1 into develop Jan 19, 2022
@mdimjasevic mdimjasevic deleted the fs-333/mdimjasevic-doc-test-cases-m2-release branch January 19, 2022 13:59
@fisx fisx mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

+1 more reviewer

@mythsunwind mythsunwind mythsunwind approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdimjasevic @pcapriotti @mythsunwind