Fix doubtless HLint issues in Federator #2011
Conversation
| throw InvalidRoute | ||
| -- check that the path has the expected form | ||
| (componentSeg, rpcPath) <- case Wai.pathInfo req of | ||
| ["federation", comp, rpc] -> pure (comp, rpc) | ||
| _ -> throw InvalidRoute | ||
|
|
||
| when (not (Text.all isAllowedRPCChar rpcPath)) $ | ||
| unless (Text.all isAllowedRPCChar rpcPath) $ |
There was a problem hiding this comment.
I like this change, but I doubt that it's non-controversial. :) Let's see if anybody complains.
There was a problem hiding this comment.
They seem to be exactly the opposite of each other:
when p s = if p then s else pure ()
unless p s = if p then pure () else sSo, I'm wondering how this could be controversial. 🤔
There was a problem hiding this comment.
it's clearly still correct, just a question of style: is code easier to read if with fewer keywords, or with less complexity in boolean expressions? i'm also leaning towards unless, and i think we're way too deep into a bike shedding thing again here, so just ignore me. if somebody feels strongly, they can make a PR with an hlint rule that rolls this back, then we can bike shed. :)
|
(please add a changelog line.) |
supersven
force-pushed
the
sventennie/hlint-federator
branch
from
9b76041 to
6c3fbf9
Compare
|
good to merge! |
Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.