Skip to content

schema-profunctor: better optional field API #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2021
Merged

schema-profunctor: better optional field API #1988

merged 2 commits into from
Dec 17, 2021

Conversation

pcapriotti
Copy link
Contributor

Improved the API for optional fields, and made it harder to misuse it. See README for more details.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti mentioned this pull request Dec 13, 2021
Merged
8 tasks
@pcapriotti pcapriotti requested a review from smatting December 17, 2021 11:14
@pcapriotti pcapriotti merged commit e4503ff into develop Dec 17, 2021
@pcapriotti pcapriotti deleted the pcapriotti/schema-profunctor-optional branch December 17, 2021 12:42
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcapriotti @smatting