Skip to content

sftd chart: add config key additionalArgs #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2021
Merged

sftd chart: add config key additionalArgs #1972

merged 3 commits into from
Dec 6, 2021

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Dec 6, 2021

This PR adds additionalArgs config key to the SFTD chart. It's intended for testing purposes.
Context: https://wearezeta.atlassian.net/browse/FS-265

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.

@smatting smatting requested a review from akshaymankar December 6, 2021 14:45
@smatting
Copy link
Contributor Author

smatting commented Dec 6, 2021

I manually tested the chart on the adhoc-testing environement.

@smatting smatting merged commit 0a2c0fe into develop Dec 6, 2021
@smatting smatting deleted the FS-265-sftd-add-args branch December 6, 2021 15:33
@sysvinit sysvinit mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smatting @akshaymankar