Skip to content

galley: Set request id correctly in Wai app #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

pcapriotti
Copy link
Contributor

This PR makes sure that the request ID is passed correctly to the logger on all endpoints in galley. Before the fix, only wai-route endpoints were running in an environment with the correct request ID.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti merged commit 402bdf7 into develop Dec 9, 2021
@pcapriotti pcapriotti deleted the pcapriotti/galley-reqid branch December 9, 2021 13:50
@sysvinit sysvinit mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants