Skip to content

Spar Polysemy: Split VerdictFormatStore from AReqIdStore #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Conversation

isovector
Copy link
Contributor

@isovector isovector commented Nov 11, 2021

This PR splits VerdictFormatStore from the AReqIdStore effect, which was accidentally paired together when I was separating effects.

Also did some related cleanup around orphan instances.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Also did some related cleanup around orphan instances
@isovector isovector requested a review from fisx November 11, 2021 05:20
@isovector isovector merged commit 452c4de into develop Nov 16, 2021
@isovector isovector deleted the split-eff2 branch November 16, 2021 01:18
@smatting smatting mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants