Skip to content

Spar Polysemy: Split IdPRawMetadataStore from IdP #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 13, 2021
Merged

Conversation

isovector
Copy link
Contributor

This PR splits IdpRawMetadataStore from the IdP effect, which was accidentally paired together when I was separating effects.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect.
  • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@isovector isovector requested a review from fisx November 11, 2021 04:30
@mdimjasevic mdimjasevic self-requested a review November 11, 2021 15:45
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rather straightforward. It looks good!

@fisx
Copy link
Contributor

fisx commented Nov 12, 2021

 [23 of 55] Compiling Spar.Sem.IdP.Mem
 /wire-server/services/spar/src/Spar/Sem/IdP/Mem.hs:21:12: error:
     • Occurs check: cannot construct the infinite type:
         a ~ (TypedState, a)
       Expected type: Sem (Eff.IdP : r) a -> Sem r (TypedState, a)
         Actual type: Sem (Eff.IdP : r) a -> Sem r a
     • In the expression: evState . evEff

you should be able to reproduce that locally by running

{stack,cabal} test spar

I wonder why you didn't run into it in your IDE?

@isovector
Copy link
Contributor Author

I can now. I wonder if this is weird stack caching stuff again 😕

@isovector isovector merged commit fe32ce3 into develop Nov 13, 2021
@isovector isovector deleted the split-eff1 branch November 13, 2021 20:07
@akshaymankar akshaymankar mentioned this pull request Nov 15, 2021
@smatting smatting mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants