Skip to content

Spar Polysemy: In-memory interpreters #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 24, 2021
Merged

Spar Polysemy: In-memory interpreters #1920

merged 17 commits into from
Nov 24, 2021

Conversation

isovector
Copy link
Contributor

This PR adds several in-memory interpreters for Spar's polysemy effects.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@isovector isovector requested a review from fisx November 9, 2021 21:52
isovector
isovector commented Nov 9, 2021
View reviewed changes
fisx
fisx requested changes Nov 10, 2021
View reviewed changes
services/spar/src/Spar/Sem/ScimTokenStore/Mem.hs
reinterpret $ \case
Insert st sti -> modify $ M.insert st sti
Lookup st -> gets $ M.lookup st
GetByTeam tid -> gets $ filter ((== tid) . stiTeam) . M.elems
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GetByTeam tid -> gets $ filter ((== tid) . stiTeam) . M.elems
LookupByTeam tid -> gets $ filter ((== tid) . stiTeam) . M.elems

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different PR ok?

@isovector
Copy link
Contributor Author

@fisx PTAL

@fisx fisx self-requested a review November 24, 2021 12:32
@isovector isovector merged commit 341f7a1 into develop Nov 24, 2021
@isovector isovector deleted the in-mem-interpreters branch November 24, 2021 22:56
mdimjasevic pushed a commit that referenced this pull request Nov 25, 2021
@isovector @mdimjasevic
Spar Polysemy: In-memory interpreters (#1920)
790ef27 
* Now and AssIDStore interpreters

* Add AReqIDStore.Mem

* add boolTTL helper

* Add BindCookieStore.Mem

* Add SAMLUserStore.Mem

* Make format

* Add DefaultSsoCode.Mem

* Add ScimExternalIdStore.Mem

* Add ScimTokenStore.Mem

* Add ScimUserTimesStore.Mem

* make format

* Changelog

* Pull out VerdictFormatStore

* Remove stale comment

* Also emit internal state

* Hi CI
@smatting smatting mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isovector @fisx