Skip to content

Federation: Notify remote participants when a user leaves a conversation because they were deleted #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2021
Merged

Federation: Notify remote participants when a user leaves a conversation because they were deleted #1891

merged 5 commits into from
Nov 8, 2021

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Oct 28, 2021 •
edited by akshaymankar
Loading

https://wearezeta.atlassian.net/browse/FS-41

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

mdimjasevic
mdimjasevic reviewed Oct 28, 2021
View reviewed changes
mdimjasevic
mdimjasevic reviewed Oct 28, 2021
View reviewed changes
@smatting smatting force-pushed the SQCORE-1055-notify-remote-participants branch 2 times, most recently from acc50a1 to 99b89ba Compare November 2, 2021 17:36
@smatting smatting requested a review from akshaymankar November 2, 2021 17:37
@smatting smatting marked this pull request as ready for review November 2, 2021 17:37
@smatting smatting force-pushed the SQCORE-1055-notify-remote-participants branch from 7276ef2 to 5f179b5 Compare November 3, 2021 09:22
akshaymankar
akshaymankar approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@akshaymankar akshaymankar force-pushed the SQCORE-1055-notify-remote-participants branch from e10e66e to 01dbe34 Compare November 8, 2021 09:49
@akshaymankar akshaymankar merged commit 4dbd1a5 into develop Nov 8, 2021
@akshaymankar akshaymankar deleted the SQCORE-1055-notify-remote-participants branch November 8, 2021 11:08
smatting added a commit that referenced this pull request Nov 8, 2021
@smatting
Remove FUTUREWORK, done in #1891
b1ef77b
smatting added a commit that referenced this pull request Nov 8, 2021
@smatting
Remove FUTUREWORK, done in #1891
3efc96d
smatting added a commit that referenced this pull request Nov 9, 2021
@smatting
Do not fail user deletion when a remote notification fails (#1912)
7371390 
* Refactor: withMockedFederatorAndGalley

* brig: ignore when remote notifications fail

* extend test case with a domain that is unvailable

* Remove FUTUREWORK, done in #1891

* Add changelog entry

* Refactor: Changes from review
@akshaymankar akshaymankar mentioned this pull request Nov 15, 2021
Merged
@smatting smatting mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

+1 more reviewer

@mdimjasevic mdimjasevic mdimjasevic left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @akshaymankar @mdimjasevic