Skip to content

Close GRPC client after making a request to federator #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2021
Merged

Close GRPC client after making a request to federator #1873

merged 3 commits into from
Nov 4, 2021

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Oct 20, 2021 •
edited
Loading

This is a followup PR to #1865, addressing the same issue, but for GRPC connections to the internal federator. This also takes care of cleaning of the GrpcClient in tests.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

akshaymankar
akshaymankar approved these changes Oct 21, 2021
View reviewed changes
@pcapriotti pcapriotti force-pushed the pcapriotti/close-more-grpc-clients branch from b2ce32d to 2792505 Compare November 2, 2021 17:10
@pcapriotti pcapriotti changed the base branch from develop to pcapriotti/galley-placeholders November 2, 2021 17:10
@pcapriotti pcapriotti force-pushed the pcapriotti/galley-placeholders branch from 31db8b3 to e56a756 Compare November 3, 2021 06:28
@pcapriotti pcapriotti force-pushed the pcapriotti/close-more-grpc-clients branch from 2792505 to 55494ef Compare November 3, 2021 06:31
Base automatically changed from pcapriotti/galley-placeholders to develop November 4, 2021 05:28
@pcapriotti pcapriotti force-pushed the pcapriotti/close-more-grpc-clients branch from 55494ef to b21bcd4 Compare November 4, 2021 05:30
@pcapriotti pcapriotti merged commit ea490c4 into develop Nov 4, 2021
@pcapriotti pcapriotti deleted the pcapriotti/close-more-grpc-clients branch November 4, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

@jschaul jschaul jschaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @akshaymankar @jschaul