Federation: support conversation access updates #1808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
pcapriotti/propagate-access
branch
from
4ebea26 to
378019f
Compare
pcapriotti
force-pushed
the
pcapriotti/propagate-read-receipts
branch
from
8249bc8 to
edb1772
Compare
pcapriotti
force-pushed
the
pcapriotti/propagate-access
branch
2 times, most recently
from
84a9aa5 to
fad0975
Compare
Base automatically changed from
pcapriotti/propagate-read-receipts
to
develop
September 28, 2021 09:55
pcapriotti
force-pushed
the
pcapriotti/propagate-access
branch
from
2ed2132 to
3151928
Compare
mdimjasevic
approved these changes
Sep 29, 2021
Comment on lines
252
to
253
| modelConversationAccessDataEvent :: Doc.Model | ||
| modelConversationAccessDataEvent = Doc.defineModel "ConversationAccessDataEvent" $ do |
There was a problem hiding this comment.
This was renamed by mistake.
There was a problem hiding this comment.
Fixed in a0cf82c.
| Doc.description "conversation access update event" | ||
| Doc.property "data" (Doc.ref modelConversationAccessUpdate) $ Doc.description "conversation access data" | ||
| Doc.property "data" (Doc.ref modelConversationAccessData) $ Doc.description "conversation access data" |
Also changed the name of `ConversationAccessUpdate` to `ConversationAccessData`, since it is going to be used to keep track of the current access and role, instead of just updates.
pcapriotti
force-pushed
the
pcapriotti/propagate-access
branch
from
3151928 to
a0cf82c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalises the on-conversation-updated RPC to support notifications of conversation access updates, by adding a new constructor to the corresponding "action" type.
Note: An access update can potentially trigger member deletion. The previous code was performing the access update on the database, sending the corresponding notification, then deleting members, in that order. That meant that a failure in deleting members would result in the whole request failure, even though the access update was performed successfully. So now members are deleted asynchronously in a separate thread, similarly to how notifications to bots are sent.
This is part of https://wearezeta.atlassian.net/browse/SQCORE-885 (federated conversation metadata updates).
Checklist
changelog.d.