Skip to content

Add ncurses dependency #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Add ncurses dependency #1791

merged 3 commits into from
Sep 20, 2021

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Sep 20, 2021

It seems 36f51b5 has added a runtime dependency on ncurses to spar-schema. This adds ncurses to the docker image dependencies, so that the ephemeral services and CI can run.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker run -it --entrypoint sh quay.io/wire/spar-schema:latest
/ # ldd /usr/bin/spar-schema 
	/lib/ld-musl-x86_64.so.1 (0x749341a26000)
Error loading shared library libncursesw.so.6: No such file or directory (needed by /usr/bin/spar-schema)
	libxml2.so.2 => /usr/lib/libxml2.so.2 (0x7493418fd000)
	libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x749341764000)
	libz.so.1 => /lib/libz.so.1 (0x74934174a000)
	libssl.so.1.1 => /lib/libssl.so.1.1 (0x7493416c9000)
	libcrypto.so.1.1 => /lib/libcrypto.so.1.1 (0x74934144a000)
	libgmp.so.10 => /usr/lib/libgmp.so.10 (0x7493413e3000)
	libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x749341a26000)
	libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x7493413cf000)
	liblzma.so.5 => /usr/lib/liblzma.so.5 (0x7493413ac000)
/ # apk add ncurses
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz
(1/3) Installing ncurses-terminfo-base (6.2_p20200523-r0)
(2/3) Installing ncurses-libs (6.2_p20200523-r0)
(3/3) Installing ncurses (6.2_p20200523-r0)
Executing busybox-1.31.1-r19.trigger
OK: 44 MiB in 31 packages
/ # ldd /usr/bin/spar-schema 
	/lib/ld-musl-x86_64.so.1 (0x7cd1420c5000)
	libncursesw.so.6 => /usr/lib/libncursesw.so.6 (0x7cd14206a000)
	libxml2.so.2 => /usr/lib/libxml2.so.2 (0x7cd141f41000)
	libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x7cd141da8000)
	libz.so.1 => /lib/libz.so.1 (0x7cd141d8e000)
	libssl.so.1.1 => /lib/libssl.so.1.1 (0x7cd141d0d000)
	libcrypto.so.1.1 => /lib/libcrypto.so.1.1 (0x7cd141a8e000)
	libgmp.so.10 => /usr/lib/libgmp.so.10 (0x7cd141a27000)
	libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7cd1420c5000)
	libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x7cd141a13000)
	liblzma.so.5 => /usr/lib/liblzma.so.5 (0x7cd1419f0000)

This looks like it will do the trick.

@isovector
Copy link
Contributor

Thanks for fixing this. Sorry about breaking CI :(

@fisx fisx marked this pull request as ready for review September 20, 2021 19:36
@fisx fisx merged commit 6eb4ffb into develop Sep 20, 2021
@fisx fisx deleted the pcapriotti/alpine-ncurses branch September 20, 2021 19:37
@fisx
Copy link
Contributor

fisx commented Sep 20, 2021

I still couldn't see the problem in the concourse log, though. Instead, I see this:

[...]
++ grep -v Running
++ grep -v Pending
++ kubectl -n test-6lwoy93o4o3f get pods
++ grep -v Completed
++ grep -v STATUS
++ grep -v ContainerCreating
++ awk '{print $1}'
++ xargs -n 1 '-I{}' bash -c 'printf '\''\n\n----LOGS FROM {}:\n'\''; kubectl -n test-6lwoy93o4o3f logs --tail=30 {}'
xargs: warning: options --max-args and --replace/-I/-i are mutually exclusive, ignoring previous --max-args value

----LOGS FROM cassandra-migrations-bk6kz:
Error from server (BadRequest): container "job-done" in pod "cassandra-migrations-bk6kz" is waiting to start: PodInitializing
++ true
++ kubectl -n test-6lwoy93o4o3f get pods
++ grep Pending
++ awk '{print $1}'
++ xargs -n 1 '-I{}' bash -c 'printf '\''\n\n----DESCRIBE '\''pending'\'' {}:\n'\''; kubectl -n test-6lwoy93o4o3f describe pod {}'
xargs: warning: options --max-args and --replace/-I/-i are mutually exclusive, ignoring previous --max-args value
make: *** [Makefile:270: kube-integration-setup] Error 1

Anyway I bumped alpine-deps: https://bridge-ie-concourse.zinfra.io/teams/main/pipelines/docker-images/jobs/alpine-deps/builds/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants