Skip to content

Servantify other member update #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 21, 2021
Merged

Servantify other member update #1784

merged 6 commits into from
Sep 21, 2021

Conversation

pcapriotti
Copy link
Contributor

Converted endpoint to Servant, made a qualified version and deprecated the unqualified one. This is part of https://wearezeta.atlassian.net/browse/SQCORE-885.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti mentioned this pull request Sep 17, 2021
Merged
5 tasks
@pcapriotti
Convert convMemberNotFound to ErrorDescription
4f48a86
@pcapriotti
Servantify updateOtherMember endpoint
a4af297
@pcapriotti
Add qualified endpoint stub for updateOtherMember
4140c2d
@pcapriotti
Add other member update tests
44d8876 
Add tests that notifications are sent correctly (to local users) after
updates to conversation member roles, using both the legacy and the
qualified endpoint.
@pcapriotti
Add CHANGELOG entries
639a335
@pcapriotti pcapriotti force-pushed the pcapriotti/servantify-member-update branch from e03daff to 639a335 Compare September 20, 2021 10:40
jschaul
jschaul approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! (Though CI seems to not have run successfully yet)

@pcapriotti pcapriotti merged commit c713f31 into develop Sep 21, 2021
@pcapriotti pcapriotti deleted the pcapriotti/servantify-member-update branch September 21, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcapriotti @jschaul