Skip to content

Report All Failures for Golden Tests at Once #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 14, 2021
Merged

Report All Failures for Golden Tests at Once #1746

merged 14 commits into from
Sep 14, 2021

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Sep 8, 2021 •
edited
Loading

This PR reports all failures in a golden test group before exiting and reporting the first failure. It turns each test object into a test case, compared to the way it has been, which is presenting a group of test cases as a single test case.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@mdimjasevic
WIP: Returning error values instead of asserting in IO in tests
577d064
@mdimjasevic
WIP: Returning error values instead of asserting in IO in tests
9019038
@mdimjasevic
Merge branch 'develop' of github.com:wireapp/wire-server into mdimjas…
e80ee1f 
…evic/golden-report-all-missing-files
@mdimjasevic
Merge branch 'mdimjasevic/golden-report-all-missing-files' of github.…
e5971d9 
…com:wireapp/wire-server into mdimjasevic/golden-report-all-missing-files
@mdimjasevic
Return a value instead of asserting in an IO
2081e9a 
- This enables for collecting all failures and reporting them in the
end, compared to short-circuiting on the first failure and missing to
report other failures in a test group
@mdimjasevic
Update the change log
d4b6e08
akshaymankar
akshaymankar reviewed Sep 8, 2021
View reviewed changes
@mdimjasevic
Merge branch 'develop' of github.com:wireapp/wire-server into mdimjas…
8c7a5da 
…evic/golden-report-all-missing-files
@mdimjasevic
Convert each testObject into a test case
f01edb0 
- This replaces the previous approach of using Polysemy and converting
every failure into a value of type 'TestOutcomeError a'
@mdimjasevic
Add a change log
4c39157
@mdimjasevic
Remove the outdated changelog draft file
79d038d
@mdimjasevic mdimjasevic merged commit b974397 into develop Sep 14, 2021
@mdimjasevic mdimjasevic deleted the mdimjasevic/golden-report-all-missing-files branch September 14, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdimjasevic @akshaymankar