Skip to content

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Sep 7, 2021

This converts /conversation/:cnv/self endpoints (GET and PUT) to servant, adds local-only stubs for their qualified counterparts, and deprecates the unqualified endpoints. This is only an internal change.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • Section Unreleased of CHANGELOG-draft.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If public end-points have been changed or added: does nginz need upgrade?

@pcapriotti pcapriotti changed the base branch from develop to pcapriotti/servantify-conv-name September 7, 2021 11:05
@pcapriotti pcapriotti changed the base branch from pcapriotti/servantify-conv-name to develop September 8, 2021 08:27
@pcapriotti pcapriotti force-pushed the pcapriotti/servantify-conv-self branch 2 times, most recently from 809b386 to ad18de7 Compare September 8, 2021 13:07
@pcapriotti pcapriotti force-pushed the pcapriotti/servantify-conv-self branch from ad18de7 to 9a77cd1 Compare September 8, 2021 14:08
@pcapriotti pcapriotti marked this pull request as ready for review September 8, 2021 14:09
@pcapriotti pcapriotti merged commit 82cf625 into develop Sep 9, 2021
@pcapriotti pcapriotti deleted the pcapriotti/servantify-conv-self branch September 9, 2021 05:21
akshaymankar added a commit that referenced this pull request Sep 9, 2021
@jschaul jschaul mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants