[skip ci] faster local docker image building using buildah #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaul
force-pushed
the
faster-local-docker-images
branch
from
47ab321 to
5850b71
Compare
buildah-compile.sh compiles wire-server inside an alpine-based container based on quay.io/wire/alpine-builder. the tool 'buildah' is used to mount some folders in, and to keep the stack caches of .stack and .stack-work (renamed to avoid conflicts) for the next compilation After compilation, ./buildah-make-images.sh can be used to bake individual executables into their respective docker images used by kubernetes. Usage: just run 'make buildah-docker' which will compile and upload images to quay.io under the docker tag $USER by default.
jschaul
force-pushed
the
faster-local-docker-images
branch
from
6a054dc to
24e9617
Compare
jschaul
changed the title
|
Updated description. Ready for review now. |
akshaymankar
approved these changes
Feb 3, 2021
|
We wanted to move away from I was under the impression that |
arianvp
approved these changes
Feb 3, 2021
Co-authored-by: Akshay Mankar <[email protected]>
jschaul
force-pushed
the
faster-local-docker-images
branch
from
d4c1c37 to
860a42b
Compare
Yep, ability to mount folders into a building container was the main reason to try out buildah. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildah-compile.sh compiles wire-server inside an alpine-based container based on quay.io/wire/alpine-builder.
the tool 'buildah' is used to mount some folders in, and to
keep the stack caches of .stack and .stack-work (renamed to avoid conflicts) for the next compilation.
After compilation, ./buildah-make-images.sh can be used
to bake individual executables into their respective docker images used by kubernetes.
Usage: just run 'make buildah-docker' which will compile and upload
images to quay.io under the docker tag $USER by default.
On my machine, the overhead (from a successful
stack buildof wire-server to a set of ~15 docker images locally) is 1.5 minutes. Pushing to quay.io depends on your internet connection. Pushing to a local kubernetes cluster would be faster.FUTUREWORK: build only some, not all images. (good luck figuring out the bash syntax to pass space-separated executables as arguments...)
FUTUREWORK: provide buildah using nix
FUTUREWORK: parameterize having or not
--fastand maybe also use this on CIFUTUREWORK: remove some docker makefile targets that are somewhat outdated