Skip to content

Accept any query string for externalId #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 15, 2021
Merged

Accept any query string for externalId #1330

merged 4 commits into from
Jan 15, 2021

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Jan 14, 2021 •
edited
Loading

This PR will update the behaviour of GET /scim/v2/Users?filter=externalId eq "<x>". Without this PR if <x> is not en email the endpoint will return a 400. With this PR it will return an empty result set.

For context: https://wearezeta.atlassian.net/browse/SQSERVICES-204

jschaul
jschaul reviewed Jan 14, 2021
View reviewed changes
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any change to the API should also have a test added that makes use of that API functionality to A) document the desired behaviour and B) avoid future regressions.

jschaul
jschaul reviewed Jan 14, 2021
View reviewed changes
jschaul
jschaul approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(comment would be nice, otherwise looks good!)

@smatting smatting force-pushed the SQSERVICES-204-external-filter branch from f17f336 to a4899e9 Compare January 14, 2021 18:25
fisx
fisx approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but please add the something along the lines of the comment i suggested.

@smatting smatting merged commit 9732876 into develop Jan 15, 2021
@smatting smatting deleted the SQSERVICES-204-external-filter branch January 15, 2021 12:48
@smatting smatting mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul approved these changes

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @jschaul @fisx