Search contacts by email inside team. #1286
Conversation
fisx
changed the title
fisx
force-pushed
the
fisx/es-updates
branch
from
daec004 to
7721e35
Compare
|
@fisx Feel free to "review" :) |
smatting
changed the title
services/brig/src/Brig/IO/Intra.hs
Outdated
| @@ -172,9 +173,10 @@ updateSearchIndex orig e = case e of | |||
| or | |||
| [ isJust eupName, | |||
| isJust eupAccentId, | |||
| isJust eupHandle | |||
| isJust eupHandle, | |||
| isJust eupManagedBy | |||
There was a problem hiding this comment.
@smatting Wanted to split this into two PRs I think. One for the general search endpoint and another one for sorting and filtering for these additional properties.
There was a problem hiding this comment.
idp: I've added a commit for that
role: not possible (easily) as this change to role originates in galley and I couldn't find an existing mechanism for creating Events (Brig.User.Event) externally
| Doc.response 200 "The search result." Doc.end | ||
|
|
||
| get "/teams/:tid/search" (continue browseTeamH) $ |
There was a problem hiding this comment.
With this route, should it be moved to the module where the other routes under /teams/:tid/ are stored?
Donno, our routing table tree is a bit out of sorts anyway, so I'm not sure how to keep this from getting worse. Leaving it here makes sense because it's also about searching.
There was a problem hiding this comment.
Generally /teams/{tid}/... makes sense when you need the teamId. That would match the pattern for most of the team endpoints looking from the outside.
There was a problem hiding this comment.
I'd also prefer keeping it closer to search and the cost to lookup a path in the code is quite low
| withSettingsOverrides newOpts f <* deleteIndex opts indexName | ||
| withSettingsOverrides newOpts f |
There was a problem hiding this comment.
left-over from debugging and accidentally commited. I reverted it
Co-authored-by: fisx <[email protected]>
Co-authored-by: fisx <[email protected]>
| ) -> | ||
| Handler Response | ||
| teamUserSearchH (_ ::: uid ::: tid ::: mQuery ::: mRoleFilter ::: mSortBy ::: mSortOrder ::: size) = do | ||
| json <$> teamUserSearch uid tid mQuery (undefined mRoleFilter) mSortBy mSortOrder size |
There was a problem hiding this comment.
What is this undefined doing here?
There was a problem hiding this comment.
It was probably a reminder to not use this argument. mbRoleFilter has the wrong type for the function call. A quick and dirty way to make the type checker happy. It wouldn't cause problems since mRoleFilter, mSortB, mSortOrder are not used, but I should have caught this in my review, and it shouldn't get released like this.
https://wearezeta.atlassian.net/browse/SQSERVICES-145
Stefan:
This PR adds a new endpoint
/teams/:tid/searchto brig that allows admins to search for team members. A reindex is required for this endpoint to work. If reindexing is skipped all existing endpoints that make use of ES are still fully functional.