Skip to content

Conversation

@github-actions
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


TaskWPB-21303 [iOS] maintenance of critical flows

This reverts commit f26eb8f.

Issue

As stars are up now, this reverts disabling the critical flows from running. See #3793

Testing

N/A


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian marked this pull request as draft October 29, 2025 14:48
@caldrian caldrian marked this pull request as ready for review October 29, 2025 14:48
…0-1bee47a6d5b39d044f2d03c7ae5897276fad5681' into chore/revert-disable-tests-cherry-pick
@caldrian caldrian enabled auto-merge October 29, 2025 14:54
@caldrian caldrian disabled auto-merge October 29, 2025 15:06
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 29, 2025

Test Results

1 892 tests   1 782 ✅  9m 53s ⏱️
  306 suites     27 💤
    2 files       83 ❌

For more details on these failures, see this check.

Results for commit 842d465.

♻️ This comment has been updated with latest results.

@caldrian caldrian enabled auto-merge October 29, 2025 16:04
@caldrian caldrian added this pull request to the merge queue Oct 29, 2025
auto-merge was automatically disabled October 29, 2025 16:29

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2025
@netbe netbe added this pull request to the merge queue Oct 29, 2025
@netbe netbe removed this pull request from the merge queue due to a manual request Oct 29, 2025
@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 30, 2025

⚠️ Tests

⚠️ Warnings

🧪 186 Tests failed

testImageModeAllAccountTypesAndAvailabilities() from WireAccountImageUITests.AccountImageViewSnapshotTests (Datadog)
AccountImageViewSnapshotTests.swift:64: XCTAssertNil failed: "Snapshot "dark" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/WireUI/Tests/WireAccountImageUITests/Resources/ReferenceImages/AccountImageViewSnapshotTests/imageMode_noAvailability.dark.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/WireUI/Tests/WireAccountImageUITests/Resources/SnapshotResults/AccountImageViewSnapshotTests/imageMode_noAvailability.dark.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...
testTextModeAllAccountTypesAndAvailabilities() from WireAccountImageUITests.AccountImageViewSnapshotTests (Datadog)
AccountImageViewSnapshotTests.swift:91: XCTAssertNil failed: "Snapshot "dark" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/WireUI/Tests/WireAccountImageUITests/Resources/ReferenceImages/AccountImageViewSnapshotTests/textMode_noAvailability.dark.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/WireUI/Tests/WireAccountImageUITests/Resources/SnapshotResults/AccountImageViewSnapshotTests/textMode_noAvailability.dark.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...

    testAccountSwitcher() from WireAuthenticationUITests.AccountSwitcherViewTests

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 23408c0 | Docs | Was this helpful? Give us feedback!

@netbe netbe added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@netbe netbe enabled auto-merge October 30, 2025 12:07
@netbe netbe added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@findms findms added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@findms findms added this pull request to the merge queue Oct 30, 2025
@findms findms added this pull request to the merge queue Nov 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2025
@findms findms enabled auto-merge November 4, 2025 09:16
@findms findms added this pull request to the merge queue Nov 4, 2025
auto-merge was automatically disabled November 4, 2025 09:43

Pull Request is not mergeable

@findms findms removed this pull request from the merge queue due to a manual request Nov 4, 2025
@caldrian caldrian enabled auto-merge November 4, 2025 17:44
@caldrian caldrian disabled auto-merge November 5, 2025 08:56
@caldrian caldrian enabled auto-merge November 5, 2025 08:56
@caldrian caldrian changed the base branch from develop to release/cycle-4.10 November 6, 2025 09:58
@caldrian caldrian force-pushed the chore/revert-disable-tests-cherry-pick branch from 4ebdec8 to 842d465 Compare November 7, 2025 11:06
@caldrian caldrian changed the base branch from release/cycle-4.10 to update-simulator-sdk-WPB-20880 November 7, 2025 11:08
…le-tests-cherry-pick

# Conflicts:
#	fastlane/.env
@caldrian caldrian merged commit 0bc900c into update-simulator-sdk-WPB-20880 Nov 7, 2025
5 checks passed
@caldrian caldrian deleted the chore/revert-disable-tests-cherry-pick branch November 7, 2025 11:55
@caldrian caldrian restored the chore/revert-disable-tests-cherry-pick branch November 7, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants