fix(types): added rejections (ExceptionHandler) to Logger interface #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svaj
force-pushed
the
fix/rejections-typedef
branch
from
1cc5a9a to
62c6c28
Compare
This was referenced Jan 13, 2022
vanflux
added a commit
to vanflux/winston
that referenced
this pull request
Jan 13, 2022
Added RejectionHandler to Logger interface, Basically the same of PR: winstonjs#1929 Suggest by: winstonjs#2021 (comment)
fearphage
pushed a commit
that referenced
this pull request
Jan 13, 2022
* RejectionHandlers added to LoggerOptions The 'rejectionHandlers' field was missing on LoggerOptions interface at index.d.ts. Issue: #1801 * Added handleRejections field to LoggerOptions. A complement to rejectionHandlers commit. * Added RejectionHandler to Logger interface Added RejectionHandler to Logger interface, Basically the same of PR: #1929 Suggest by: #2021 (comment)
Contributor
|
We merged #2021 instead, which incorporates these changes, so I'm going to go ahead and close this out. Thanks for helping us reach a good solution here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1928 and adds rejections to the Logger interface