Skip to content

fix(transport): eol='' not work #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2021
Merged

fix(transport): eol='' not work #1878

merged 1 commit into from
Dec 11, 2021

Conversation

@adoyle-h
Copy link
Contributor

@adoyle-h adoyle-h commented Jan 13, 2021

new winston.transports.Console({eol: ''}) not work. Because Boolean('') equals false.

DABH
DABH approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DABH DABH merged commit a584db3 into winstonjs:master Dec 11, 2021
@Omrisnyk Omrisnyk mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DABH DABH DABH approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adoyle-h @DABH