Fix: chart loading can fail, and cause the entire page to render as a white screen, when using Turbolinks #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…]}); (without a callback) crashes the page in Chrome 31
winston
added a commit
that referenced
this pull request
Nov 24, 2013
Fix: chart loading can fail, and cause the entire page to render as a white screen, when using Turbolinks
Owner
|
This is great! Thank you! And sorry for taking so long to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug comes up when using Turbolinks. I've been able to replicate it in Chrome 31 and Firefox 24 - though the test harness only works in FF because Turbolinks doesn't run on localhost in Chrome (due to security policy).
I'm not sure exactly why (haven't dove deep enough into Google's code yet), but calling
google.load('visualization','1', {packages: ['corechart']});without acallbackis the culprit. The issue comes up when Turbolinks inserts the script and causes the browser to execute it.My fix is to add a
callbackreferring to the given function. This way you're still able to refer to the function by name, without the bug occurring.