fix(app): ensure result selection completes in tutorial step 14 #6818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=80&v=4){kind=small}
The tutorial step 14 was moving to the next step immediately after clicking the result button, without waiting for the click to complete and the UI to update. This caused the input component not to be linked to the runnable input. Fixed by: - Making onNextClick properly async - Adding await wait(100) after the click to ensure UI updates - Removing unnecessary setTimeout wrapper Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Deploying windmill with
|
| Latest commit: |
557a9b4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f638cf02.windmill.pages.dev |
| Branch Preview URL: | https://claude-issue-6817-20251014-1.windmill.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6817
Summary
Fixed the app tutorial step 14 where the result was not being selected, causing the input component not to be linked to the runnable input.
Changes
onNextClickhandler properly asyncawait wait(100)after clicking the result buttonsetTimeoutwrapperTesting
npm run check)🤖 Generated with Claude Code