Skip to content

Conversation

breiler
Copy link
Collaborator

@breiler breiler commented Mar 10, 2025

Fixes a problem where a program like this could not be loaded:

G17 G21 G90 G94 G54 M0 M5 M9
G0 X10  Y10.0   F8.0
G02 X20 Y0      R-10

NCViewer displays it like this:
image

There were two problems. A check was in place to prevent negative radius values which was removed. But we also needed to handle the special case to invert the angle when there is a negative radius. Of there these fixes it now displays correctly with:

image

Also prevent spamming error dialogs when loading gcode with multiple errors. Removed unused parameter for spindle speed.

Relates to #2710

@breiler breiler changed the title Prevent spamming error dialogs when loading gcode with multiple errors Fix problem with arcs with negative radius Mar 11, 2025
@breiler breiler merged commit 6553550 into winder:master Mar 11, 2025
1 check passed
@breiler breiler deleted the arc-radius branch March 11, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant