Skip to content

Conversation

Sasiprakash-UoA
Copy link

The issue I have addressed: #817

What I Did:

  • Added logic to detect portrait-oriented (vertical) videos based on width and height

  • Applied conditional padding using Angular’s [ngStyle] to .filmstrip-container

  • Vertical videos now use tighter padding (2px 4px) to reduce wasted horizontal space

  • Landscape videos retain default padding (10px) to maintain consistent appearance

  • Included a console.log(video.width, video.height) for easy debugging if needed

Why It Matters:

  • Fixes visual imbalance in Filmstrip View when vertical videos are displayed

  • Enhances space efficiency and makes the layout look cleaner

  • Keeps the logic isolated to filmstrip.component without touching other views or styles

Thanks again for the amazing project!

@whyboris
Copy link
Owner

Thank you @Sasiprakash-UoA for the contribution! 😁
I'll test-drive this to make sure it doesn't unpleasantly shift anything in the gallery layout 🤝
I'll try to get to PR reviews at the end of summer 🙇

@Sasiprakash-UoA
Copy link
Author

No worries @whyboris!
I'm glad that I got to work on this wonderful repo and made some contributions. Thank you for the opportunity!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants