Uc notebook asset #83
Open
+424
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still TODO, we should link to docs from instructions that reference creating a foriegn catalog
Co-authored-by: Kelly-Ann Dolor <[email protected]>
Co-authored-by: Kelly-Ann Dolor <[email protected]>
Co-authored-by: Kelly-Ann Dolor <[email protected]>
Co-authored-by: Kelly-Ann Dolor <[email protected]>
Co-authored-by: Kelly-Ann Dolor <[email protected]>
Co-authored-by: Kelly-Ann Dolor <[email protected]>
Co-authored-by: Kelly-Ann Dolor <[email protected]>
Co-authored-by: Kelly-Ann Dolor <[email protected]>
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/wherobots/wherobots-examples/pull/83 |
|
This is ready for review. |
Comment on lines
+130
to
+131
| "from pyspark.sql.functions import expr, col, when, lit\n", | ||
| "from pyspark.sql.functions import lit" |
| "\n", | ||
| "# Define the point of interest (Tokyo) as a WKT string.\n", | ||
| "\n", | ||
| "tokyo_geom_wkt = \"POINT (139.6917 35.6895)\"\n", |
There was a problem hiding this comment.
should we use wkls here? Should we use a geometry instead of a point?
| "# Wherobots efficiently calculates the spherical distance in meters for every row.\n", | ||
| "df_with_distance = df_w_geom.withColumn(\n", | ||
| " \"distance_to_tokyo_meters\",\n", | ||
| " expr(f\"ST_DistanceSphere(point, ST_SetSRID(ST_GeomFromWKT('{tokyo_geom_wkt}'), 4326))\")\n", |
There was a problem hiding this comment.
setting the SRID probably doesnt accomplish anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.