Skip to content

Conversation

sfishel18
Copy link
Contributor

still TODO, we should link to docs from instructions that reference creating a foriegn catalog

Copy link

Copy link

gitnotebooks bot commented Aug 15, 2025

Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/wherobots/wherobots-examples/pull/81

@sfishel18 sfishel18 force-pushed the simon/databricks-examples branch from 3516cca to 0bb08b3 Compare August 15, 2025 21:46
still TODO, we should link to docs from instructions that reference creating
a foriegn catalog
@sfishel18 sfishel18 force-pushed the simon/databricks-examples branch from 0bb08b3 to 9bdb7ce Compare August 15, 2025 21:50
Copy link

@kcheng486 kcheng486 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadolor im not too familiar with notebook authoring guidelines, the use of "we" and "you" in this is a bit strange to me but otherwise this seems fine to me?

"# Before You Begin\n",
"This example assumes you have already created a Delta-format foreign catalog connection to Databricks Unity Catalog, which contains a Delta table to operate on. This Delta table must contain a geometry column with values encoded in WKT format.\n",
"\n",
"If you plan to write the data to an Iceberg table in Unity Catalog, you will need another Iceberg-format foreign catalog connection.\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand what ultimately is providing here but I may be lacking context

" \"properties\": {},\n",
" \"geometry\": {\n",
" \"type\": \"Polygon\", \n",
" \"coordinates\": [\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this AOI?

Copy link
Contributor

@kadolor kadolor Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aminianp I'm not sure it exists--I think this notebook is positioned as: 'You already connected your notebook and here's an example of an ETL procedure'.

I think there needs to be further contextualizing at the beginning about how customers should read this notebook, that is, as general guidance through the ETL process depending on the type of Table you're loading and writing to.

@kcheng486 @RoboDonut If lines 1-4 were filled in with valid values by someone running this notebook, my assumption is that this notebook would still error out, is that correct?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I don't quite follow why this would error out? presumably it would just give nothing if no data was found within the AOI? that said the polygon seems like it only spans a very small area in the Gulf of Guinea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadolor i think the point you're making is that if the data in your foreign catalog doesn't happen to line up with the aoi, then you'll get an empty data set when you apply the filter. am i understanding you correctly?

Copy link

@aminianp aminianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nit comments here and there; otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants