-
Notifications
You must be signed in to change notification settings - Fork 1
configs: torch-2.9 xpu configs #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are steps I used to verify pytorch xpu variant build (these are steps, not a working shell script as there are few missing parts which are assumed such as installed or built variantlib, variant-repack and intel-variant-provider):
And in other shell we can install (on Intel GPU compatible system this should install xpu pytorch variant):
|
c164ecc
to
391f18a
Compare
391f18a
to
791c364
Compare
Alright I added NV config and rebased on master. Let's wait a little bit - I'm confirming a few details |
791c364
to
9126696
Compare
@DEKHTIARJonathan, thank you for update. |
9126696
to
b509ff5
Compare
@dvrogozh If I use the pip installation instructions from "1. With patched pip from", it installs from the
Is that what we want though? It looks like the latest changes are being added to the pep-xxx-wheel-variants-dev branch. Installing pip directly from that branch might be needed:
That commit |
@jithunnair-amd, that's what I have tested and what worked for me. As for whether that's what we want, I hope so since the decision was made to use the main branch as a driving point. I did not dive under the hood after that on what is being fetched from where. It might be that you have spotted a misconfiguration - submit and issue or ping folks in wheelnext on Slack. My personal opinion is that for the better consistency all branches except main and release branches should be completely pruned from wheelnext repos and folks should start create user forks to avoid a mess in the upstream (which is wheelnext). |
By the way, remember that pip is not a goal right now,
|
Signed-off-by: Dmitry Rogozhkin <[email protected]>
5b2ff8a
to
ff0b1c5
Compare
normalize_package_name = false | ||
normalize_version = true | ||
deps_remove_list = [ | ||
# XPU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DEKHTIARJonathan , why did not you list deps to remove here for Nvidia? did you miss them or there is a logic change anywhere for nvidia or in variant-repack?
Close - will re-open from a branch inside this repo |
This PR starts cooking Pytorch 2.9 variant configs. At the moment:
This PR requires these versions of plugins:
CC: @atalman @DEKHTIARJonathan