-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Describe integration with the WeakRefs proposal #4571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5aa7783
Describe integration with the WeakRefs proposal
littledan 64762e1
Editorial: Add cross-reference
littledan 979b9fb
Changes from review from Anne and Mathieu
littledan 02d7ca5
Move WeakRef processing logic back to the WeakRef specification
littledan 37de013
ClearKeptObjects in microtask checkpoint algorithm
littledan 65407e9
Report the exception from CleanupFinalizationGroup
littledan 531e610
Clean up definition of garbage collection task source
littledan 8fda8e0
Editorial cleanup in HostCleanupFinalizationGroup
littledan 5bfbfd2
Rename FinalizationGroup to FinalizationRegistry
littledan ec9b8f1
cleanupSome must be omitted; follow up in issues
littledan ec24205
Editorial changes.
Ms2ger 78b5ca9
Specify handling of entry and incumbent objects.
Ms2ger b03f374
fixup! Specify handling of entry and incumbent objects.
Ms2ger 906bc7c
Review comment
Ms2ger 3e6f119
Remove reference to proposal since WeakRefs have been merged into ecm…
syg 7d4e6aa
Depend on https://github.com/tc39/ecma262/pull/2316 for incumbent mac…
syg e0611bb
Remove cleanupSome reference since that was split out into separate p…
syg 2bbab42
Address review; move FR hook into job-integration section
syg f06928d
Add notes about ClearKeptObjects
syg 44b79e1
Refine ClearKeptObjects note to not suggest that it dies due to Clear…
syg f7041ef
Broaden incumbent tracking in Promises to also include FinalizationRe…
syg cb0f44e
Address domenic review
syg 557bd3d
formatting
annevk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.