Fix #234, proper error handling

[pderaaij]

No description provided.

[pderaaij]

I have the same fix in #248.

Guess there are still some promise issues in oas-validator which we need to find, but it shouldn't break speccy like it does right now.

[philsturgeon]

@MikeRalphson I know there have been a lot of changes in oas-validator recently, should I merge this or wait for the updates?

[philsturgeon]

@pderaaij hey could you update the changelog for this? It should go under an Unreleased header instead of a specific version for now.

[pderaaij]

@philsturgeon this appears not to be the correct fix. I found the correct one for #248.

I will update the PR in a few minutes.

[pderaaij]

@philsturgeon Updated the PR, this is a proper fix

[philsturgeon]

Thank you @pderaaij. I'm going to leave it to @MikeRalphson to review this one, if he approves I'll be happy to merge it.

[MikeRalphson]

@pderaaij should I test this one against the released [email protected] or against the upcoming release? If the latter, how are you linking the unreleased code to Speccy to test, referencing git urls in package.json or using npm link or some other approach?

[pderaaij]

@MikeRalphson I've tested it against 2.0.1 as well as the current state of v5prep. For the latter I take a poor mans approach of copying the last files in the branch to node_modules.

The fix should work in both cases.

[MikeRalphson]

Should it not be?

const { context, lintResults, valid } = _options || err.options;

        if (err && valid === false) {

[MikeRalphson]

With the above change, Speccy gives the correct output and exit code on my invalid, minimal and minimalLintable examples, which I can post in a gist if useful. This is with both the released and unreleased version of oas-validator.

[MikeRalphson]

Now LGTM! PR should probably be squashed to aid any future git bisect etc.

[pderaaij]

Thanks for the review. I need to get used to all the new options in Javascript. Long time ago I developed in javascript/node.js ;-)

[MikeRalphson]

Long time ago I developed in javascript/node.js ;-)

Doesn't show, I'd hate to try and write any Java or C# today!

[dkarlovi]

Is there a way for me to fetch a Docker image with this baked in so I can test it against #253?

[philsturgeon]

@dkarlovi sorry bud I was asleep! :) Merged now, so docker hub should be updated soon.

[dkarlovi]

@philsturgeon sweet, just ran nightly, it indeed fixed the issue, thanks. 👍