Help wanted: Enhancement: port new linter rule to Speccy

[MikeRalphson]

Detailed description

oas-kit has a new linter rule definition and example rule as suggested on the APIs you won't hate Slack.

It provides simple if/then functionality for dependent properties.

See Mermade/oas-kit@ef89a29

Context

At the moment Speccy leverages a lot of oas-kit directly, but uses a ported version of the linter code. Suggestions on how to bring these closer together would be welcomed.

Possible implementation

Should be relatively simple copy and paste, but would require a new test and docs update.

[philsturgeon]

Hey @MikeRalphson, thanks for bringing this over. I'm working on getting the two systems closer together:

1. switching to YAML
2. disable: true instead of enable: true

But one problem I'm having in using oas-linter is that it doesn't really handle skip rules in a way I can use. Maybe you could look at this branch: https://github.com/wework/speccy/pull/204/files

Passing them into init isnt working, but seeing as linter is called from validator I'm struggling to get them in another way. The way it currently works in that branch, if you npm test, I think its race conditioning, with various tests resetting the array before its called from others.

I've tried a lot of different approaches, put a day or two into rewriting it, trying to get #163 solved, but I'm a bit stuck. Ideas very welcome! :)

[MikeRalphson]

I'll take a look when I get a chance. I think the other big difference is gathering lint warnings together rather than bombing on the first one?

[MikeRalphson]

I've raised a PR on better-ajv-errors to add handling for ~0 and ~1 escapes, which is basically a must have for reporting errors / warnings under paths. atlassian/better-ajv-errors#33

[philsturgeon]

#248 should take care of this, and then we won’t need to maintain two sets of rules anymore :)