fix firered/subsampling.py where x_mask shape may not be same as x shape #2789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当我使用wenet进行firered 的encoder部分导出时，我发现，
输入encoder的batch size==1， 如果事先手动给feat进行padding(例如从1013 padding到2000)，但是输入的feat_len为1013时，会产生错误。具体报错截图如下：
具体分析发现，在firered/subsampling文件中，没有保证在padding right_context后的x_mask和x的seq等长。
所以在该情况下，我在下面显示地将两者做了一个对齐