Use the same handler for binary and text messages #939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges
receiver.onbinary
andreceiver.ontext
intoreceiver.onmessage
.I think thank using 2 different handlers is pointless.
This is tagged as "major" because it changes the
Receiver
interface but I don't think many people are using theReceiver
andSender
classes directly. Their interface is not documented and imo they should be private and not used directly. Unfortunately they are exposed as static properties of theWebSocket
class.I was also thinking that maybe it makes sense to emit to the
WebSocket
instance directly instead of using these wrapper functions.For example we could make the
Receiver
constructor accept aWebSocket
instance, the one the receiver is bound to.and then instead of calling the wrapper functions like this, emit the event directly on the
websocket
object.