Issue path validation #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I second the importance of this change. |
|
The old way: If the client connects with a wrong path, the connection will hang. Both the server and the client can know what hanppened. I think the server should tell to the client what happened. |
lpinca
reviewed
Oct 17, 2016
| @@ -2081,7 +2081,11 @@ describe('WebSocket', function() { | |||
| }); | |||
| ws.on('close', function() { | |||
| setTimeout(function() { | |||
| assert.ok(errorGiven); | |||
| if (errorGiven) { | |||
There was a problem hiding this comment.
I don't get this change. The assertion is useless now as it's always true.
|
Can you please add a test for this? Thank you. |
|
ok |
added 2 commits
October 17, 2016 21:23
When a client visits a server with a wrong path, the connection should be rejected.
fatelei
force-pushed
the
issue-path-validation
branch
from
c2071c9 to
52f0b33
Compare
fatelei
force-pushed
the
issue-path-validation
branch
from
52f0b33 to
98af262
Compare
|
@lpinca I have added a test |
|
@fatelei thank you. LGTM. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client visits a server with a wrong path, the connection should be rejected.