[failOnError] show eslint errors when failOnError is disabled #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 251 253 +2
Branches 71 72 +1
=========================================
+ Hits 251 253 +2
Continue to review full report at Codecov.
|
GertSallaerts
force-pushed
the
fix/fail-on-error-display
branch
2 times, most recently
from
603ea35 to
78b79d0
Compare
GertSallaerts
force-pushed
the
fix/fail-on-error-display
branch
from
78b79d0 to
72c52f0
Compare
|
Hi @GertSallaerts |
|
Ahh...thanks for PR 😄 |
ricardogobbosouza
approved these changes
Feb 16, 2021
alexander-akait
approved these changes
Feb 17, 2021
|
Thanks for your quick work on this one @GertSallaerts and @ricardogobbosouza 🚀 Any idea when this will be released? |
|
Hi @ZLevine |
|
@ricardogobbosouza thanks! I see it now :) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Eslint errors are no longer shown when you disable
failOnError. See #84Breaking Changes
Additional Info