Define opSupportLimits() #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
suggested changes
Aug 27, 2024
fdwr
approved these changes
Aug 30, 2024
huningxin
approved these changes
Aug 30, 2024
Contributor
huningxin
left a comment
huningxin
left a comment
There was a problem hiding this comment.
@philloooo , thanks for the substantial work!
LGTM with some minor comments.
fdwr
approved these changes
Aug 30, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
👍 LGTM. I'll let Ningxin look over once more since your changes.
github-actions bot
added a commit
that referenced
this pull request
Aug 30, 2024
SHA: 49eeebf Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
huningxin
reviewed
Sep 2, 2024
| MLSupportLimits bias; | ||
| MLSupportLimits recurrentBias; | ||
| MLSupportLimits peepholeWeight; | ||
| MLSupportLimits output; |
Contributor
There was a problem hiding this comment.
It should be outputs because lstmCell also returns a sequence of operands. Spotted in Chromium CL review: https://chromium-review.googlesource.com/c/chromium/src/+/5821811/comment/43ea6f39_e85e92e4/
huningxin
added a commit
to huningxin/webnn
that referenced
this pull request
Sep 2, 2024
`MLLstmCellSupportLimits.outputs` reflects that lstmCell returns a sequence of operands. Fix webmachinelearning#755 (comment)
huningxin
added a commit
to huningxin/webnn
that referenced
this pull request
Sep 2, 2024
`MLLstmCellSupportLimits.outputs` reflects that lstmCell returns a sequence of operands. Fix webmachinelearning#755 (comment)
fdwr
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ts` (#757) `MLLstmCellSupportLimits.outputs` reflects that lstmCell returns a sequence of operands. Fix #755 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463 by defining opSupportLimits.
Defering rankRange until we implement the prototype.
@reillyeon @huningxin @fdwr
Preview | Diff